LoadStringA can't return string resource directly #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's actually impossible for the ANSI version of LoadString to be implemented as documented, because the string resources are stored in Unicode only. If you try to call LoadStringA with cchBufferMax=0, it will attempt to null-terminate the 0-length buffer (i.e. it will do `lpBuffer[-1] = 0`, corrupting nearby memory), and return -1.
|
|
|
@DankRank : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
riverar
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's actually impossible for the ANSI version of LoadString to be implemented as documented, because the string resources are stored in Unicode only.
If you try to call LoadStringA with cchBufferMax=0, it will attempt to null-terminate the 0-length buffer (i.e. it will do
lpBuffer[-1] = 0, corrupting nearby memory), and return -1.