Skip to content

Conversation

@X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Sep 15, 2019

The Set-AdfsProperties document page has a corrupted version of the EnableOAuthDeviceFlow parameter in its parameter list, and is also missing the parameter details for this.

@opbld31
Copy link

opbld31 commented Sep 15, 2019

Docs Build status updates of commit c97ac65:

✅ Validation status: passed

File Status Preview URL Details
docset/windows/adfs/set-adfsproperties.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@o0nj
Copy link
Contributor

o0nj commented Sep 16, 2019

@dariomws306 @get-itips @tseward

Peer review needed for this PR. Thanks.

Copy link
Contributor

@dariomws dariomws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Enables the OAuth Device Flow." could be better

@opbld33
Copy link

opbld33 commented Sep 16, 2019

Docs Build status updates of commit 15e993d:

✅ Validation status: passed

File Status Preview URL Details
docset/windows/adfs/set-adfsproperties.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@opbld31
Copy link

opbld31 commented Sep 17, 2019

Docs Build status updates of commit bb60f89:

✅ Validation status: passed

File Status Preview URL Details
docset/windows/adfs/set-adfsproperties.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@ghost
Copy link

ghost commented Sep 17, 2019

Looks good.

@o0nj
Copy link
Contributor

o0nj commented Sep 23, 2019

@get-itips Any additional comments?

Copy link
Contributor

@get-itips get-itips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@get-itips Any additional comments?

no more than the ones I have already submitted in the review.

@opbld32
Copy link

opbld32 commented Sep 23, 2019

Docs Build status updates of commit 105086d:

✅ Validation status: passed

File Status Preview URL Details
docset/windows/adfs/set-adfsproperties.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@o0nj o0nj added the Sign off The pull request is ready to be reviewed and merged by PubOps label Sep 25, 2019
@v-raaba v-raaba added In review PubOps is reviewing the pull request and removed Sign off The pull request is ready to be reviewed and merged by PubOps labels Sep 25, 2019
@opbld30
Copy link

opbld30 commented Sep 25, 2019

Docs Build status updates of commit 6816f59:

✅ Validation status: passed

File Status Preview URL Details
docset/windows/adfs/set-adfsproperties.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@v-raaba
Copy link
Contributor

v-raaba commented Sep 25, 2019

@e0i is it expected that PR is merging to live? We are used to merging PRs to master.

We publish to the live branch from master everyday at 10:30 PST & 3:30 PST. It would be preferrable if contributers PRed against master. This would ensure that master is in Sync with live.

@dstrome David, adding you to this message for your input. It would be best if the PubOps Github Admins do not have to merge live into master before publishing everytime.
So it would be best if external contributors submitted to master only and not to live.

@v-raaba v-raaba added Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates and removed In review PubOps is reviewing the pull request labels Sep 25, 2019
@o0nj
Copy link
Contributor

o0nj commented Sep 30, 2019

@X-Guardian Please change the target branch of this PR to master so that we can proceed with the PR review. Thanks.

@X-Guardian
Copy link
Contributor Author

How do I do that without starting the pull request again?

All I've done is selected the Edit button on the Set-AdfsProperties Documentation Page which is configured to edit the md file in the live branch. If you want editors to do anything different,that link needs to be changed.

@o0nj
Copy link
Contributor

o0nj commented Sep 30, 2019

@X-Guardian

Try editing this pull request via the Edit button at the top right corner. You may then click to the branch link and change the target. Thanks.

@X-Guardian X-Guardian changed the base branch from live to master September 30, 2019 15:29
@X-Guardian
Copy link
Contributor Author

OK done, but someone still needs to get that Edit button changed, or all future edits from anyone are all going to end up with PRs linking to the live branch.

@o0nj o0nj added Sign off The pull request is ready to be reviewed and merged by PubOps and removed Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates labels Sep 30, 2019
@claydetels19 claydetels19 removed the Sign off The pull request is ready to be reviewed and merged by PubOps label Sep 30, 2019
@claydetels19 claydetels19 merged commit 20542c6 into MicrosoftDocs:master Sep 30, 2019
@X-Guardian X-Guardian deleted the patch-2 branch October 24, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants