-
Notifications
You must be signed in to change notification settings - Fork 621
Update set-adfsproperties.md with corrupt/missing EnableOAuthDeviceFlow Parameter details #1301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Docs Build status updates of commit c97ac65: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
@dariomws306 @get-itips @tseward Peer review needed for this PR. Thanks. |
dariomws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "Enables the OAuth Device Flow." could be better
|
Docs Build status updates of commit 15e993d: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
Docs Build status updates of commit bb60f89: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
Looks good. |
|
@get-itips Any additional comments? |
get-itips
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@get-itips Any additional comments?
no more than the ones I have already submitted in the review.
|
Docs Build status updates of commit 105086d: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
Docs Build status updates of commit 6816f59: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
@e0i is it expected that PR is merging to We publish to the @dstrome David, adding you to this message for your input. It would be best if the PubOps Github Admins do not have to merge |
|
@X-Guardian Please change the target branch of this PR to |
|
How do I do that without starting the pull request again? All I've done is selected the |
|
Try editing this pull request via the Edit button at the top right corner. You may then click to the branch link and change the target. Thanks. |
|
OK done, but someone still needs to get that |
The
Set-AdfsPropertiesdocument page has a corrupted version of theEnableOAuthDeviceFlowparameter in its parameter list, and is also missing the parameter details for this.