Skip to content

Conversation

@velkovb
Copy link
Contributor

@velkovb velkovb commented Jun 25, 2021

Add info about character limit in TXT records
#2423

Add info about character limit in TXT records
MicrosoftDocs#2423
@opbld32
Copy link

opbld32 commented Jun 25, 2021

Docs Build status updates of commit 8466fb3:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (winserver2012-ps)
docset/winserver2012r2-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2016-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy review.

Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
@opbld31
Copy link

opbld31 commented Jun 25, 2021

Docs Build status updates of commit bbe1112:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (winserver2012-ps)
docset/winserver2012r2-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2016-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@o0nj o0nj requested review from a user, dariomws and get-itips June 28, 2021 11:09
@o0nj o0nj added the Sign off The pull request is ready to be reviewed and merged by PubOps label Jul 19, 2021
@v-dihans v-dihans self-assigned this Jul 19, 2021
@v-dihans v-dihans added the In review PubOps is reviewing the pull request label Jul 19, 2021
@opbld32
Copy link

opbld32 commented Jul 19, 2021

Docs Build status updates of commit 1ca2021:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (winserver2012-ps)
docset/winserver2012r2-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2016-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Jul 19, 2021

Docs Build status updates of commit bbaab96:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (winserver2012-ps)
docset/winserver2012r2-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2016-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/dnsserver/Add-DnsServerResourceRecord.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@v-dihans
Copy link
Contributor

Hi @velkovb

Merging with non-blocking feedback.

 
Following are non-blocking issues that should be resolved now or within three business days in another PR:

docset/winserver2012-ps/dnsserver/Add-DnsServerResourceRecord.md

  • Line 168: Fix the link. Markdown shows on staging. Also change the "http" to "https" and remove the "en-us" from the link.
    I noticed that the link actually redirects to another url. You might want to update the link.

docset/winserver2012r2-ps/dnsserver/Add-DnsServerResourceRecord.md

  • Line 170: Fix the link. Markdown shows on staging. Also change the "http" to "https" and remove the "en-us" from the link.
    I noticed that the link actually redirects to another url. You might want to update the link.

Reference

Criteria used for pull request reviews

  • The content preview must be clean on staging. It cannot contain any obvious formatting issues.
  • With rare exceptions, all instances of "http" are changed to "https" in Microsoft links.
  • Links to pages on docs.microsoft.com sites are coded as locale agnostic, meaning that the URL does not include a locale, such as en-us, en-gb, en-in, or any other locale.

Also noticed several existing links in the articles that need to have the "http" changed to "https" and the "en-us" removed.
Those could be fixed or updated as well.

Thanks

@v-dihans v-dihans merged commit 4d70902 into MicrosoftDocs:master Jul 19, 2021
@velkovb velkovb deleted the fix/2423-missing-info branch July 25, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

In review PubOps is reviewing the pull request Sign off The pull request is ready to be reviewed and merged by PubOps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants