Missing ManagementPointNetworkType param #2531
Conversation
|
|
| The acceptable values for this parameter are: | ||
| ```yaml | ||
| Singleton: Uses the traditional method of DHCP or static IP address. |
There was a problem hiding this comment.
| Singleton: Uses the traditional method of DHCP or static IP address. | |
| Singleton: The traditional method of DHCP or static IP address. (Default setting) |
| ```yaml | ||
| Singleton: Uses the traditional method of DHCP or static IP address. | ||
| Distributed: Use a Distributed Network Name by using Node IP addresses. | ||
| Automatic: Uses detection to determine the appropriate setting. If SQL Server is running in Azure, uses Distributed. If SQL Server is running on-premises, uses Singleton (default setting). |
There was a problem hiding this comment.
| Automatic: Uses detection to determine the appropriate setting. If SQL Server is running in Azure, uses Distributed. If SQL Server is running on-premises, uses Singleton (default setting). | |
| Automatic: Automatically detects the appropriate setting. If SQL Server is running in Azure, uses `Distributed`. If SQL Server is running on-premises, uses `Singleton`. |
|
|
||
| Required: False | ||
| Position: Named | ||
| Default value: None |
There was a problem hiding this comment.
| Default value: None | |
| Default value: Singleton |
Double check this information to ensure accuracy. I'm making this changes based on your changes in the list of values above.
There was a problem hiding this comment.
When I used PlatyPS for WS2022, the default value was None.
There was a problem hiding this comment.
I believe that Automatic is the default value for this parameter, according to the few sources I've seen.
|
Docs Build status updates of commit e7a7bea: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
| The acceptable values for this parameter are: | ||
| - Automatic: Automatically detects the appropriate setting. If SQL Server is running in Azure, uses `Distributed`. If SQL Server is running on-premises, uses `Singleton`. (Default Setting) |
There was a problem hiding this comment.
| - Automatic: Automatically detects the appropriate setting. If SQL Server is running in Azure, uses `Distributed`. If SQL Server is running on-premises, uses `Singleton`. (Default Setting) | |
| - Automatic: Automatically detects the appropriate setting. If SQL Server is running in Azure, uses `Distributed`. If SQL Server is running on-premises, uses `Singleton`. (Default setting.) |
| - Automatic: Automatically detects the appropriate setting. If SQL Server is running in Azure, uses `Distributed`. If SQL Server is running on-premises, uses `Singleton`. (Default Setting) | ||
| - Singleton: The traditional method of DHCP or static IP address. | ||
| - Distributed: Use a Distributed Network Name by using Node IP addresses. |
There was a problem hiding this comment.
| - Distributed: Use a Distributed Network Name by using Node IP addresses. | |
| - Distributed: Uses a Distributed Network Name by using Node IP addresses. |
|
@chasewilson Changes should be added, let me know if you see anything else. |
|
Docs Build status updates of commit d8da01a: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
| New-Cluster [-Name] <String> [-Node <StringCollection>] [-StaticAddress <StringCollection>] | ||
| [-IgnoreNetwork <StringCollection>] [-NoStorage] [-S2D] [-AdministrativeAccessPoint <AdminAccessPoint>] | ||
| [-Force] [<CommonParameters>] | ||
| [-Force] [-ManagementPointNetworkType {Automatic | Singleton | Distributed}] [<CommonParameters>] |
There was a problem hiding this comment.
| [-Force] [-ManagementPointNetworkType {Automatic | Singleton | Distributed}] [<CommonParameters>] | |
| [-Force] [-ManagementPointNetworkType <AdminAccessPointResType>] [<CommonParameters>] |
There was a problem hiding this comment.
At least as far as I can find examining the cmdlet in PowerShell, the defined parameter type is object so I don't think this change would be correct.
(Get-Command New-Cluster).Parameters.ManagementPointNetworkType.ParameterType
IsPublic IsSerial Name BaseType
-------- -------- ---- --------
True True Object There was a problem hiding this comment.
The parameter type is indeed AdminAccessPointResType according to PlatyPs:
There was a problem hiding this comment.
Let me know what you think @chasewilson but we usually honor PlatyPs
There was a problem hiding this comment.
Yup usually the best thing to do. Good by me
There was a problem hiding this comment.
Aside from the single casing fix from @JohanFreelancer9, I think this looks good.
|
Docs Build status updates of commit a0fbfa4: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit 058c21a: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
@PatAltimore Is this change included in your PR? |
Thanks @sdwheeler. I updated the 2022 PR to match this change. |
|
Docs Build status updates of commit 1929403: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
o0nj
added
the
Sign off
|
Docs Build status updates of commit c79d3f5: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
12 participants
Adding in documentation around the ManagementPointNetworkType parameter for this command.