-
Notifications
You must be signed in to change notification settings - Fork 619
Update Update-IscsiTargetPortal.md #2549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed spot where two lines were merged into one
|
Docs Build status updates of commit 366b04e: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok, but it would look better if you enclose the commands and output as described here:
https://docs.microsoft.com/PowerShell/scripting/community/contributing/powershell-style-guide?view=powershell-7.1#executable-examples
|
Also agreed w/ @dariomws suggestion |
Merge from upstream
|
Docs Build status updates of commit 1d4658e: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending @dariomws suggestion
Based on requested change "it would look better if you enclose the commands and output"... The command and output were _already_ enclosed in a "```" block, starting with lines way above the one line that was changed for this patch. But the existing lines were enclosed in a single "```". So, not being clear about what was being asked to be changed, since only the last line within that already existing block was changed... simply added the "Output" tag between the commands and output - but again, that's _way_ above the line that was changed for this patch "patch-2".
|
Based on requested change "it would look better if you enclose the commands and output"... The command and output were already enclosed in a " |
|
Docs Build status updates of commit cfd307c: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue. This comment lists only the first 50 files in the pull request. docset/winserver2019-ps/iscsi/Update-IscsiTargetPortal.md
docset/winserver2019-ps/failoverclusters/Add-ClusterDisk.yml
docset/winserver2019-ps/netswitchteam/Remove-NetSwitchTeam.yml
docset/winserver2019-ps/netsecurity/Set-NetFirewallInterfaceFilter.yml
docset/winserver2019-ps/netsecurity/Get-NetIPsecDospSetting.yml
docset/winserver2019-ps/netsecurity/Rename-NetFirewallRule.yml
docset/winserver2019-ps/netsecurity/Show-NetFirewallRule.yml
docset/winserver2019-ps/netwnv/Get-NetVirtualizationCustomerRoute.yml
docset/winserver2019-ps/nettcpip/Get-NetTransportFilter.yml
docset/winserver2019-ps/nettcpip/Remove-NetRoute.yml
docset/winserver2019-ps/nettcpip/Set-NetRoute.yml
docset/winserver2019-ps/netadapter/Set-NetAdapterAdvancedProperty.yml
docset/winserver2019-ps/netsecurity/Get-NetFirewallApplicationFilter.yml
docset/winserver2019-ps/netsecurity/Set-NetFirewallInterfaceTypeFilter.yml
docset/winserver2019-ps/nfs/Get-NfsClientgroup.yml
docset/winserver2019-ps/netadapter/New-NetAdapterAdvancedProperty.yml
docset/winserver2019-ps/netsecurity/Get-NetFirewallInterfaceFilter.yml
docset/winserver2019-ps/nettcpip/Get-NetRoute.yml
docset/winserver2019-ps/netsecurity/Copy-NetIPsecMainModeRule.yml
docset/winserver2019-ps/netsecurity/Disable-NetFirewallRule.yml
docset/winserver2019-ps/netwnv/New-NetVirtualizationProviderRoute.yml
docset/winserver2019-ps/nfs/Set-NfsMappingStore.yml
docset/winserver2019-ps/netsecurity/Remove-NetIPsecPhase2AuthSet.yml
docset/winserver2019-ps/netwnv/Get-NetVirtualizationGlobal.yml
docset/winserver2019-ps/netsecurity/Rename-NetIPsecPhase1AuthSet.yml
docset/winserver2019-ps/netsecurity/New-NetIPsecRule.yml
docset/winserver2019-ps/nettcpip/Set-NetTCPSetting.yml
docset/winserver2019-ps/netsecurity/Remove-NetIPsecPhase1AuthSet.yml
docset/winserver2019-ps/nfs/Get-NfsClientConfiguration.yml
docset/winserver2019-ps/netadapter/Reset-NetAdapterAdvancedProperty.yml
docset/winserver2019-ps/networktransition/Get-NetDnsTransitionMonitoring.yml
docset/winserver2019-ps/netsecurity/Copy-NetIPsecPhase2AuthSet.yml
docset/winserver2019-ps/printmanagement/Get-PrinterPort.yml
docset/winserver2019-ps/netwnv/Set-NetVirtualizationProviderRoute.yml
docset/winserver2019-ps/pki/Get-CertificateEnrollmentPolicyServer.yml
docset/winserver2019-ps/nfs/Get-NfsNetgroupStore.yml
docset/winserver2019-ps/netswitchteam/Get-NetSwitchTeam.yml
docset/winserver2019-ps/netwnv/New-NetVirtualizationCustomerRoute.yml
docset/winserver2019-ps/netsecurity/New-NetIPsecQuickModeCryptoProposal.yml
docset/winserver2019-ps/netsecurity/Set-NetFirewallAddressFilter.yml
docset/winserver2019-ps/printmanagement/Rename-Printer.yml
docset/winserver2019-ps/networktransition/New-NetNatTransitionConfiguration.yml
docset/winserver2019-ps/networktransition/Get-NetDnsTransitionConfiguration.yml
docset/winserver2019-ps/remoteaccess/Connect-VpnS2SInterface.yml
docset/winserver2019-ps/networktransition/Set-NetDnsTransitionConfiguration.yml
docset/winserver2019-ps/netsecurity/New-NetIPsecPhase2AuthSet.yml
docset/winserver2019-ps/netsecurity/New-NetIPsecPhase1AuthSet.yml
docset/winserver2019-ps/netsecurity/Get-NetFirewallServiceFilter.yml
docset/winserver2019-ps/netsecurity/Update-NetIPsecRule.yml
docset/winserver2019-ps/netsecurity/Get-NetFirewallInterfaceTypeFilter.yml
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
Thanks @Rob-S. |
|
Docs Build status updates of commit 708b3bb: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit 2db5cf5: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue. This comment lists only the first 50 files in the pull request. docset/winserver2019-ps/iscsi/Update-IscsiTargetPortal.md
docset/winserver2019-ps/mpio/Get-MSDSMAutomaticClaimSettings.yml
docset/winserver2019-ps/mpio/Disable-MSDSMAutomaticClaim.yml
docset/winserver2019-ps/ipamserver/Import-IpamRange.yml
docset/winserver2019-ps/netlbfo/New-NetLbfoTeam.yml
docset/winserver2019-ps/netadapter/Disable-NetAdapterQos.yml
docset/winserver2019-ps/msdtc/New-DtcDiagnosticTransaction.yml
docset/winserver2019-ps/msmq/Get-MsmqQueueACL.yml
docset/winserver2019-ps/netadapter/Enable-NetAdapterRsc.yml
docset/winserver2019-ps/msdtc/Complete-DtcDiagnosticTransaction.yml
docset/winserver2019-ps/netadapter/Disable-NetAdapterVmq.yml
docset/winserver2019-ps/netadapter/Get-NetAdapterIPsecOffload.yml
docset/winserver2019-ps/msdtc/Install-Dtc.yml
docset/winserver2019-ps/msmq/Move-MsmqMessage.yml
docset/winserver2019-ps/netadapter/Get-NetAdapterVmq.yml
docset/winserver2019-ps/netadapter/Enable-NetAdapterIPsecOffload.yml
docset/winserver2019-ps/netsecurity/Remove-NetIPsecMainModeCryptoSet.yml
docset/winserver2019-ps/msdtc/Get-Dtc.yml
docset/winserver2019-ps/msdtc/Start-Dtc.yml
docset/winserver2019-ps/msmq/Get-MsmqQueue.yml
docset/winserver2019-ps/failoverclusters/Add-ClusterDisk.yml
docset/winserver2019-ps/nettcpip/Set-NetTCPSetting.yml
docset/winserver2019-ps/netadapter/Get-NetAdapterSriovVf.yml
docset/winserver2019-ps/netadapter/Get-NetAdapterVmqQueue.yml
docset/winserver2019-ps/nettcpip/Get-NetIPv4Protocol.yml
docset/winserver2019-ps/netsecurity/Disable-NetFirewallRule.yml
docset/winserver2019-ps/netadapter/Get-NetAdapterRdma.yml
docset/winserver2019-ps/netadapter/Disable-NetAdapterIPsecOffload.yml
docset/winserver2019-ps/kds/Set-KdsConfiguration.yml
docset/winserver2019-ps/netadapter/Get-NetAdapterEncapsulatedPacketTaskOffload.yml
docset/winserver2019-ps/netadapter/Enable-NetAdapter.yml
docset/winserver2019-ps/netadapter/Enable-NetAdapterQos.yml
docset/winserver2019-ps/netadapter/Get-NetAdapterPowerManagement.yml
docset/winserver2019-ps/nettcpip/Get-NetIPv6Protocol.yml
docset/winserver2019-ps/netadapter/Enable-NetAdapterRdma.yml
docset/winserver2019-ps/netlbfo/Add-NetLbfoTeamMember.yml
docset/winserver2019-ps/msdtc/Receive-DtcDiagnosticTransaction.yml
docset/winserver2019-ps/msdtc/Get-DtcTransactionsTraceSession.yml
docset/winserver2019-ps/netsecurity/Get-NetIPsecQuickModeCryptoSet.yml
docset/winserver2019-ps/netsecurity/Remove-NetIPsecDospSetting.yml
docset/winserver2019-ps/msdtc/Join-DtcDiagnosticResourceManager.yml
docset/winserver2019-ps/netsecurity/Copy-NetFirewallRule.yml
docset/winserver2019-ps/netadapter/Get-NetAdapterBinding.yml
docset/winserver2019-ps/ipamserver/Import-IpamAddress.yml
docset/winserver2019-ps/msdtc/Uninstall-Dtc.yml
docset/winserver2019-ps/netadapter/Enable-NetAdapterRss.yml
docset/winserver2019-ps/netsecurity/Save-NetGPO.yml
docset/winserver2019-ps/nettcpip/Set-NetRoute.yml
docset/winserver2019-ps/kds/Get-KdsConfiguration.yml
docset/winserver2019-ps/netadapter/Set-NetAdapterPowerManagement.yml
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
When I try click on that link above, it says: I am not a Microsoft employee. In hindsight, when changes were requested, I should have pointed that out. The original submission (and numerous previous submissions) was to point out an error in the documentation. In this case the error was that two separate lines had been improperly joined into a single line, and the line with the next command needed to be moved to a separate line, below the block of output that it had been combined with. As this is the mechanism for reporting errors, what happens is the update to correct the specific error in one of the versions (the one where the error was discovered) gets submitted through this process. Other than that specific change, which points out what the error in the page is, if any other changes, such as the cosmetic changes requested, are desired, I would claim that responsibility would fall on a Microsoft employee. Just as when a Microsoft employee, upon receiving notification regarding an error on one of the version-specific pages, it would be the responsibility of the Microsoft employee receiving that notification to propagate the correction of that error to all other versions of the page where that same error occurs and ensure it is incorporated into future versions of the page as well. And I have no idea what "PlatyPS" is. |
|
Docs Build status updates of commit 8144087: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue. This comment lists only the first 50 files in the pull request. docset/winserver2019-ps/iscsi/Update-IscsiTargetPortal.md
docset/winserver2019-ps/failoverclusters/Add-ClusterDisk.yml
docset/winserver2019-ps/fileserverresourcemanager/Set-FsrmFileGroup.yml
docset/winserver2019-ps/fileserverresourcemanager/Get-FsrmStorageReport.yml
docset/winserver2019-ps/fileserverresourcemanager/New-FsrmStorageReport.yml
docset/winserver2019-ps/international/Get-WinCultureFromLanguageListOptOut.yml
docset/winserver2019-ps/mmagent/Enable-MMAgent.yml
docset/winserver2019-ps/iscsitarget/Get-IscsiVirtualDiskSnapshot.yml
docset/winserver2019-ps/international/Get-WinDefaultInputMethodOverride.yml
docset/winserver2019-ps/msdtc/Get-Dtc.yml
docset/winserver2019-ps/fileserverresourcemanager/New-FsrmQuotaTemplate.yml
docset/winserver2019-ps/mpio/Set-MSDSMGlobalDefaultLoadBalancePolicy.yml
docset/winserver2019-ps/fileserverresourcemanager/Update-FsrmAutoQuota.yml
docset/winserver2019-ps/mmagent/Disable-MMAgent.yml
docset/winserver2019-ps/ipamserver/Add-IpamCustomField.yml
docset/winserver2019-ps/fileserverresourcemanager/Stop-FsrmStorageReport.yml
docset/winserver2019-ps/iscsi/Get-IscsiConnection.yml
docset/winserver2019-ps/iscsitarget/Import-IscsiVirtualDisk.yml
docset/winserver2019-ps/msdtc/Undo-DtcDiagnosticTransaction.yml
docset/winserver2019-ps/fileserverresourcemanager/Remove-FsrmQuotaTemplate.yml
docset/winserver2019-ps/msdtc/Receive-DtcDiagnosticTransaction.yml
docset/winserver2019-ps/fileserverresourcemanager/Set-FsrmQuotaTemplate.yml
docset/winserver2019-ps/ipamserver/Export-IpamAddress.yml
docset/winserver2019-ps/fileserverresourcemanager/New-FsrmFileGroup.yml
docset/winserver2019-ps/msdtc/Get-DtcClusterTMMapping.yml
docset/winserver2019-ps/msdtc/Complete-DtcDiagnosticTransaction.yml
docset/winserver2019-ps/iscsi/Connect-IscsiTarget.yml
docset/winserver2019-ps/msdtc/Join-DtcDiagnosticResourceManager.yml
docset/winserver2019-ps/fileserverresourcemanager/Start-FsrmStorageReport.yml
docset/winserver2019-ps/msdtc/Remove-DtcClusterTMMapping.yml
docset/winserver2019-ps/msdtc/Add-DtcClusterTMMapping.yml
docset/winserver2019-ps/msdtc/Set-DtcNetworkSetting.yml
docset/winserver2019-ps/ipamserver/Invoke-IpamGpoProvisioning.yml
docset/winserver2019-ps/fileserverresourcemanager/Set-FsrmStorageReport.yml
docset/winserver2019-ps/iscsitarget/Dismount-IscsiVirtualDiskSnapshot.yml
docset/winserver2019-ps/iscsi/Update-IscsiTarget.yml
docset/winserver2019-ps/iscsitarget/Get-IscsiVirtualDisk.yml
docset/winserver2019-ps/iscsitarget/Set-IscsiVirtualDiskSnapshot.yml
docset/winserver2019-ps/netadapter/Disable-NetAdapterQos.yml
docset/winserver2019-ps/msdtc/Uninstall-Dtc.yml
docset/winserver2019-ps/ipamserver/Get-IpamConfiguration.yml
docset/winserver2019-ps/fileserverresourcemanager/Get-FsrmFileGroup.yml
docset/winserver2019-ps/msmq/Send-MsmqQueue.yml
docset/winserver2019-ps/mpio/Remove-MSDSMSupportedHW.yml
docset/winserver2019-ps/netadapter/Enable-NetAdapterChecksumOffload.yml
docset/winserver2019-ps/msdtc/Set-DtcLog.yml
docset/winserver2019-ps/iscsitarget/Convert-IscsiVirtualDisk.yml
docset/winserver2019-ps/msmq/Get-MsmqQueue.yml
docset/winserver2019-ps/iscsi/Get-IscsiTarget.yml
docset/winserver2019-ps/netadapter/Disable-NetAdapterLso.yml
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
@Rob-S You are not allowed to have paragraphs between codeblocks in an example. This is a limitation of PlatyPS, the tool that is used to build the docs. I made changes to the file that should fix this. See the contributors guide for more information. https://docs.microsoft.com/powershell/scripting/community/contributing/powershell-style-guide?#formatting-cmdlet-reference-articles |
|
Docs Build status updates of commit 4d5fdb9: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit 84c041a: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|

Fixed spot where two lines were merged into one