Skip to content

Update microsoft-store-services-sdk.md#155

Merged
mcleanbyron merged 3 commits intoMicrosoftDocs:docsfrom
LanceMcCarthy:docs
Jul 26, 2017
Merged

Update microsoft-store-services-sdk.md#155
mcleanbyron merged 3 commits intoMicrosoftDocs:docsfrom
LanceMcCarthy:docs

Conversation

@LanceMcCarthy
Copy link
Copy Markdown
Contributor

Updated Step 6 in the NuGet package installation directions section. Until you restart Visual Studio, you will not see the Extension SDK in the list.

Updated Step 6 in the NuGet package installation directions. Until you restart Visual Studio, you will not see the extension SDK in the list.
@msftclas
Copy link
Copy Markdown

@LanceMcCarthy,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@mcleanbyron
Copy link
Copy Markdown
Contributor

Thank you for your contribution. I and several other people have tested the current instructions several times and the existing steps work fine for us (that is, we can add the "Microsoft Advertising SDK for XAML" assembly reference after simply closing and reopening the project; we don't need to close and restart Visual Studio at step 6).

I am following up with the engineering team who owns this SDK to confirm the correct instructions, but can you please try the existing steps again with just closing and reopening the project to confirm that this doesn't work for you?

@LanceMcCarthy
Copy link
Copy Markdown
Contributor Author

I unloaded and reloaded the UWP Project and didn't see either Extension SDK (Advertising or Services) under 'Add Reference > Universal Windows > Extensions'.

When you say "closing and reopening" do you mean the solution?

If yes, then we only need to update the docs to say "Close and reopen the Solution' instead of "project"

@LanceMcCarthy
Copy link
Copy Markdown
Contributor Author

LanceMcCarthy commented Jul 26, 2017

Okay, I just did a "File > New" test and confirmed the following:

  • Closing and re-opening the UWP project does not update the Extension SDKs list
  • Closing and re-opening the Solution does update the Extension SDKs list

I can change my PR to say "Close and reopen the solution" instead of "Restart Visual Studio"

LanceMcCarthy and others added 2 commits July 26, 2017 14:15
Updates Step 6 in NuGet package instructions to 'close and reopen the solution'
Copy link
Copy Markdown
Contributor

@mcleanbyron mcleanbyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, and good call on clarifying that it is the solution that needs to be closed and reopened rather than the project. I am merging your pull request, with a few minor edits.

@mcleanbyron mcleanbyron merged commit 3a92c6d into MicrosoftDocs:docs Jul 26, 2017
mijacobs pushed a commit that referenced this pull request May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants