Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical selection considers him self a snake #1839

Closed
mc-butler opened this issue Nov 20, 2009 · 22 comments
Closed

Vertical selection considers him self a snake #1839

mc-butler opened this issue Nov 20, 2009 · 22 comments
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.7.0-pre4 Reproducible in version 4.7.0-pre4
Milestone
4.7.0

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/1839
Reporter styx (@styx)

Test example:
..
...
....
.....
......
..............
.............
............
...........
..........
..*1...*2..

Select from *1 to *2 with vertical selection and continue with pressing up until you can see snake effect (:
@mc-butler
Copy link
Author

Changed by styx (@styx) on Nov 20, 2009 at 14:41 UTC (comment 1)

  • Owner set to angel_il
  • Status changed from new to assigned

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Nov 20, 2009 at 18:31 UTC (comment 2)

  • Severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.0

branch: 1839_vertical_selection_enhancement
changeset: [bbd4a849ea8f0acd7469215bd30af52c831bbe03]

@mc-butler
Copy link
Author

Changed by styx (@styx) on Nov 21, 2009 at 10:16 UTC (comment 3)

  • Severity changed from on review to on rework

Yeah, it is nice of course, you fixed bug with cursor jumping, but this bug is another one (
Just try to perform a test case.

@mc-butler
Copy link
Author

Changed by styx (@styx) on Nov 23, 2009 at 16:23 UTC (comment 4)

  • Severity changed from on rework to on review
  • Votes set to styx

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Nov 24, 2009 at 9:53 UTC (comment 5)

  • Severity changed from on review to approved
  • Votes changed from styx to styx slavazanko

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Nov 24, 2009 at 13:34 UTC (comment 6)

  • Severity changed from approved to on rework
  • Votes styx slavazanko deleted

@mc-butler
Copy link
Author

Changed by styx (@styx) on Nov 24, 2009 at 17:25 UTC (comment 7)

  • Votes set to styx

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Nov 24, 2009 at 19:23 UTC (comment 8)

  • Severity changed from on rework to on review

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Nov 24, 2009 at 20:00 UTC (comment 9)

  • Severity changed from on review to approved
  • Votes changed from styx to styx slavazanko

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Nov 24, 2009 at 20:33 UTC (comment 10)

  • Votes changed from styx slavazanko to committed-master
  • Severity changed from approved to merged
  • Status changed from assigned to testing
  • Resolution set to fixed

fixed: [f648fbc]

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Nov 24, 2009 at 20:34 UTC (comment 11)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Dec 4, 2009 at 12:18 UTC (comment 12)

  • Resolution fixed deleted
  • Status changed from closed to reopened

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Dec 4, 2009 at 12:20 UTC (comment 13)

Test example:

..
...
....
<------>.....
......
<------>..............
.............
<------>............
...........
..........
<------>*1...*2..

Select from *1 to *2 with vertical selection and delete block.

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Dec 4, 2009 at 12:21 UTC (comment 14)

  • Severity changed from merged to on review
  • Votes committed-master deleted

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Dec 4, 2009 at 12:35 UTC (comment 15)

branch: 1839_vertical_block_delete_fix
changeset: [51bc8adc7ab865c61ff58b3d7237855ee066805c]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Dec 4, 2009 at 15:34 UTC (comment 16)

  • Votes set to slavazanko

In master: text deleted to the end of string
In branch: text deleted as well.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 4, 2009 at 16:32 UTC (comment 17)

Unforunately, doesn't work.

Test case:

  1. Create file as described in comment:13
  2. Place cursor at *1 position.
  3. Press S-F3 and press Right to place cursor at *2 position.
  4. Press Up to top line to select vertical block.
  5. Press F8 do delete that block.
  6. Result: in each line the part between *1 position and the line end have been deleted.

Need rework.

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Dec 7, 2009 at 11:20 UTC (comment 18)

  • Severity changed from on review to on rework

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Dec 8, 2009 at 11:33 UTC (comment 17.19)

  • Severity changed from on rework to on review

Replying to andrew_b:

Unforunately, doesn't work.

Test case:

  1. Create file as described in comment:13
  2. Place cursor at *1 position.
  3. Press S-F3 and press Right to place cursor at *2 position.
  4. Press Up to top line to select vertical block.
  5. Press F8 do delete that block.
  6. Result: in each line the part between *1 position and the line end have been deleted.

Need rework.

fixed, please review

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 9, 2009 at 11:27 UTC (comment 20)

  • Severity changed from on review to approved
  • Votes changed from slavazanko to slavazanko andrew_b

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Dec 9, 2009 at 11:55 UTC (comment 21)

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Severity changed from approved to merged
  • Votes changed from slavazanko andrew_b to committed-master

fixed: [31a46ce]

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Feb 21, 2025 at 7:21 UTC (comment 22)

Ticket #1739 has been marked as a duplicate of this ticket.

@mc-butler mc-butler marked this as a duplicate of #1739 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.7.0-pre4 Reproducible in version 4.7.0-pre4
Milestone
4.7.0
Development

No branches or pull requests
1 participant
@mc-butler