[PATCH] Save input line content in history only if has changed

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/2545
Reporter	cosoleto (cosoleto@….com)
Mentions	gotar@….pl

It's possible users reuse the same content of a dialog or just
enable/disable some options available, then saving the history is
pointless.

Note

Original attachments:

• 0001-Save-input-line-content-in-history-only-if-has-chang.patch (raw) by cosoleto (cosoleto@….com) on Apr 28, 2011 at 3:13 UTC

[mc-butler]

Changed by andrew_b (@aborodin) on Jan 1, 1970 at 0:21 UTC

• Blocked by #2541 deleted

(In #2541) Merged to master.
[fcfa76b]

git log --pretty=oneline 417d550..fcfa76b

[mc-butler]

Changed by cosoleto (cosoleto@….com) on Apr 28, 2011 at 3:13 UTC

• Attachment 0001-Save-input-line-content-in-history-only-if-has-chang.patch (raw) added

Patch

[mc-butler]

Changed by slavazanko (@slavaz) on May 3, 2011 at 11:18 UTC (comment 1)

• Owner set to slavazanko
• Status changed from new to accepted

[mc-butler]

Changed by slavazanko (@slavaz) on May 3, 2011 at 11:21 UTC (comment 2)

• Owner changed from slavazanko to andrew_b
• Blocked by set to #2541
• Status changed from accepted to assigned

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 29, 2011 at 7:02 UTC (comment 3)

The proposed patch is not quite correct. Comparison of input content and top of history is not enough to decide whether the history was changed or not. E.g. history list supports the delete capability of its items (see #1445). If user made some clean up of history but didn't change the input content, the history should be saved.

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 1, 2011 at 8:59 UTC (comment 4)

• Severity changed from no branch to on review
• Milestone changed from 4.8 to 4.8.0-pre1
• Keywords set to stable-candidate

Created 2545_save_history branch (parent: master).
Initial [a9e8ed4d28480fa2e2cea52b96d64a6209374cf0]

[mc-butler]

Changed by slavazanko (@slavaz) on Jul 7, 2011 at 8:58 UTC (comment 5)

• Votes set to slavazanko

[mc-butler]

Changed by iNode (@iNode) on Jul 7, 2011 at 9:42 UTC (comment 6)

• Votes changed from slavazanko to slavazanko iNode
• Severity changed from on review to approved

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 7, 2011 at 10:19 UTC (comment 7)

• Votes changed from slavazanko iNode to committed-master
• Severity changed from approved to merged

Merged to master.
[7d52669]

git log --pretty=oneline f3ae923..7d52669

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 7, 2011 at 10:20 UTC (comment 8)

• Status changed from assigned to testing
• Resolution set to fixed

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 7, 2011 at 17:51 UTC (comment 9)

• Severity changed from merged to on review
• Status changed from testing to reopened
• Resolution fixed deleted
• Votes committed-master deleted
• Version changed from 4.7.5 to master

The bug was introduced in [5ffcffb]. The new input content is saved in history.

Created 2545_save_history_fix branch (parent: master).
[ce49f91ab6b33a03bc253e8bce43c4f69aec5c08]

Please review.

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 7, 2011 at 17:55 UTC (comment 9.10)

Replying to andrew_b:

is saved

is not saved, of course.

[mc-butler]

Changed by slavazanko (@slavaz) on Jul 8, 2011 at 9:26 UTC (comment 11)

• Branch state set to on review
• Severity changed from on review to no branch

[mc-butler]

Changed by slavazanko (@slavaz) on Jul 8, 2011 at 9:31 UTC (comment 12)

• Votes set to slavazanko

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jul 8, 2011 at 14:19 UTC (comment 13)

• Votes changed from slavazanko to slavazanko angel_il
• Branch state changed from on review to approved