Skip to content

Conversation

@krriyo
Copy link
Contributor

@krriyo krriyo commented Jun 14, 2016

Using data instead of json parameter for post request
Opening file for byte(b) and read(r)
Removing signatories dictionary key and using the modified version with the index and internal keys

krriyo added 2 commits June 14, 2016 13:51
Using data instead of json parameter for post request
Opening file for byte(b) and read(r)
Removing signatories dictionary key and using the modified version with the index and internal keys
mifiel/base.py Outdated
if not url:
url = self.url()

if files:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets pass a files dict instead so we can use it in other models

krriyo added 2 commits June 14, 2016 17:39
Building the files dict on document
Adding .json() to the response
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 97.333% when pulling 7fa3abf on krriyo:feature/fixes into 2f0f91e on Mifiel:feature/fixes.

@genaromadrid genaromadrid merged commit 468f829 into Mifiel:feature/fixes Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants