docs: add architecture recommendations #137
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| | Recommendation | Description | | ||
| | --- | --- | | ||
| | **Do not override lifecycle methods in Activities or Fragments.**<br/>Strongly recommended | Do not override lifecycle methods such as `onResume` in Activities or Fragments. Use `LifecycleObserver` instead. If the app needs to perform work when the lifecycle reaches a certain state, use the `repeatOnLifecycle` API. | | ||
|
|
||
| The following snippet outlines how to perform operations given a certain lifecycle state: |
There was a problem hiding this comment.
[P1] Revisit prohibition on overriding lifecycle callbacks
The lifecycle section states that Activities or Fragments should not override lifecycle methods and should always use LifecycleObserver instead. That guidance is incorrect for normal Android development where onCreate, onStart, onResume, etc. are routinely overridden to set up views, register receivers, or inflate Compose content. Treating overrides as “strongly recommended” to avoid will mislead readers into thinking core APIs are off-limits and block basic app initialization. This recommendation should be softened or scoped to specific side‑effect handling rather than forbidding lifecycle overrides outright.
Useful? React with 👍 / 👎.
Summary
Testing
./gradlew test(fails: SDK location not found)https://chatgpt.com/codex/tasks/task_e_68c1b5ec66fc832d9e4115cdf84b2220