Refine onboarding flow with data consent and completion screens #151
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| binding.switchCrashlytics.setOnCheckedChangeListener((buttonView, isChecked) -> { | ||
| binding.textDetails.setVisibility(isChecked ? View.VISIBLE : View.GONE); | ||
| viewModel.setCrashlyticsEnabled(isChecked); | ||
| }); | ||
|
|
||
| binding.linkPrivacy.setOnClickListener(v -> { | ||
| Intent intent = new Intent(Intent.ACTION_VIEW, | ||
| Uri.parse("https://d4rk7355608.github.io/profile/#privacy-policy-apps")); | ||
| startActivity(intent); | ||
| }); | ||
| } | ||
|
|
||
| public void saveSelection() { | ||
| viewModel.setCrashlyticsEnabled(binding.switchCrashlytics.isChecked()); |
There was a problem hiding this comment.
[P1] Crashlytics consent toggle never disables collection
The new data-consent screen stores the user’s choice in shared preferences (setCrashlyticsEnabled), but the value is never applied to the Crashlytics SDK. There is no code anywhere in the app that reads key_firebase_crashlytics or calls FirebaseCrashlytics.getInstance().setCrashlyticsCollectionEnabled(...), so crash reports remain enabled by default regardless of the user’s selection. This presents a privacy/compliance risk because the UI promises a choice that isn’t honored. Consider applying the stored value during app startup and updating the SDK configuration whenever the setting changes.
Useful? React with 👍 / 👎.
This commit introduces several changes: - Refactored `MainUiState` and test `FakeHomeRepository` & `FakeQuizLocalDataSource` to use Java records. - Updated various icons (`ic_arrow_back`, `ic_arrow_forward`, `ic_close`, `ic_security`) with new path data and added `ic_open_new`. - Modified layout files for onboarding (`fragment_onboarding_data.xml`, `fragment_onboarding_done.xml`, `activity_onboarding.xml`) to adjust icon gravity and replace a LinearLayout with a MaterialButton. - Updated text strings and removed unused ones in `strings.xml`. - Renamed `getDailyTip()` to `dailyTip()` in `HomeRepository` and its implementations. - Added FIXME comments for potential null pointer exceptions, deprecated methods, and unused code in several Java files. - Changed GitHub username in `OpenSourceLicensesUtils.java`. - Updated card view shape appearance in `fragment_onboarding_selection.xml`. - Simplified fragment creation in `OnboardingActivity` using an enhanced switch.
Summary
Testing
./gradlew test(fails: SDK location not found)https://chatgpt.com/codex/tasks/task_e_68c3dd2bc0d8832d8a7a6122e71d75bd