Use MediaView for bottom bar native ad #166
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| <FrameLayout | ||
| android:layout_width="40dp" | ||
| android:layout_height="40dp" | ||
| android:layout_marginEnd="12dp"> | ||
|
|
||
| <com.google.android.gms.ads.nativead.MediaView | ||
| android:id="@+id/ad_media" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" /> | ||
|
|
||
| <androidx.appcompat.widget.AppCompatImageView | ||
| android:id="@+id/ad_app_icon" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:visibility="gone" /> |
There was a problem hiding this comment.
[P1] Hide icon when media asset is available
The new layout stacks MediaView and ad_app_icon in the same FrameLayout. NativeAdLoader.populateNativeAdView makes the icon view visible whenever nativeAd.getIcon() is present, without checking whether nativeAd.getMediaContent() is also provided. For ads that deliver both assets (which is the common case), the icon remains visible and sits on top of the MediaView, so the media content never becomes visible despite being loaded. This regresses the intent of switching to MediaView for the bottom bar ad. Consider hiding the icon when media content is present or showing the icon only when media is absent.
Useful? React with 👍 / 👎.
Summary
Testing
./gradlew test(fails: SDK location not found)https://chatgpt.com/codex/tasks/task_e_68c5e5d9814c832d877f2ebdcc1bddce