Skip to content

Decouple MainViewModel from Application context #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2025
Merged

Decouple MainViewModel from Application context #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions app/src/main/java/com/d4rk/androidtutorials/java/data/repository/DefaultMainRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ private static int getNewNightMode(String[] darkModeValues, int currentNightMode
/**
* Check if a given package name is installed.
*
* @param packageManager The PackageManager used to check installations.
* @param packageName The package to check.
* @param packageName The package to check.
* @return True if installed, false otherwise.
*/
public boolean isAppInstalled(PackageManager packageManager, String packageName) {
public boolean isAppInstalled(String packageName) {
PackageManager packageManager = context.getPackageManager();
try {
packageManager.getPackageInfo(packageName, 0);
return true;
Expand Down Expand Up @@ -85,14 +85,18 @@ public boolean applyThemeSettings(String[] darkModeValues) {
/**
* Retrieves the bottom navigation label visibility preference.
*/
public String getBottomNavLabelVisibility(String labelKey, String labelDefaultValue) {
public String getBottomNavLabelVisibility() {
String labelKey = context.getString(R.string.key_bottom_navigation_bar_labels);
String labelDefaultValue = context.getString(R.string.default_value_bottom_navigation_bar_labels);
return defaultSharedPrefs.getString(labelKey, labelDefaultValue);
}

/**
* Retrieves which tab should be shown by default.
*/
public String getDefaultTabPreference(String defaultTabKey, String defaultTabValue) {
public String getDefaultTabPreference() {
String defaultTabKey = context.getString(R.string.key_default_tab);
String defaultTabValue = context.getString(R.string.default_value_tab);
return defaultSharedPrefs.getString(defaultTabKey, defaultTabValue);
}

Expand Down
7 changes: 3 additions & 4 deletions app/src/main/java/com/d4rk/androidtutorials/java/data/repository/MainRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
package com.d4rk.androidtutorials.java.data.repository;

import android.content.Intent;
import android.content.pm.PackageManager;
import com.google.android.play.core.appupdate.AppUpdateManager;

public interface MainRepository {
boolean isAppInstalled(PackageManager packageManager, String packageName);
boolean isAppInstalled(String packageName);
boolean applyThemeSettings(String[] darkModeValues);
String getBottomNavLabelVisibility(String labelKey, String labelDefaultValue);
String getDefaultTabPreference(String defaultTabKey, String defaultTabValue);
String getBottomNavLabelVisibility();
String getDefaultTabPreference();
boolean shouldShowStartupScreen();
void markStartupScreenShown();
void applyLanguageSettings();
Expand Down
4 changes: 2 additions & 2 deletions ...n/java/com/d4rk/androidtutorials/java/domain/main/GetBottomNavLabelVisibilityUseCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public GetBottomNavLabelVisibilityUseCase(MainRepository repository) {
this.repository = repository;
}

public String invoke(String key, String defaultValue) {
return repository.getBottomNavLabelVisibility(key, defaultValue);
public String invoke() {
return repository.getBottomNavLabelVisibility();
}
}
4 changes: 2 additions & 2 deletions .../main/java/com/d4rk/androidtutorials/java/domain/main/GetDefaultTabPreferenceUseCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public GetDefaultTabPreferenceUseCase(MainRepository repository) {
this.repository = repository;
}

public String invoke(String key, String defaultValue) {
return repository.getDefaultTabPreference(key, defaultValue);
public String invoke() {
return repository.getDefaultTabPreference();
}
}
5 changes: 2 additions & 3 deletions app/src/main/java/com/d4rk/androidtutorials/java/domain/main/IsAppInstalledUseCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.d4rk.androidtutorials.java.domain.main;

import android.content.pm.PackageManager;
import com.d4rk.androidtutorials.java.data.repository.MainRepository;

/** Checks if an app is installed by package name. */
Expand All @@ -11,7 +10,7 @@ public IsAppInstalledUseCase(MainRepository repository) {
this.repository = repository;
}

public boolean invoke(PackageManager pm, String packageName) {
return repository.isAppInstalled(pm, packageName);
public boolean invoke(String packageName) {
return repository.isAppInstalled(packageName);
}
}
5 changes: 4 additions & 1 deletion app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/main/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,10 @@ protected void onCreate(Bundle savedInstanceState) {

setupUpdateNotifications();

mainViewModel.applySettings();
String[] themeValues = getResources().getStringArray(R.array.preference_theme_values);
String[] bottomNavBarLabelsValues = getResources().getStringArray(R.array.preference_bottom_navigation_bar_labels_values);
String[] defaultTabValues = getResources().getStringArray(R.array.preference_default_tab_values);
mainViewModel.applySettings(themeValues, bottomNavBarLabelsValues, defaultTabValues);
if (mainViewModel.shouldShowStartupScreen()) {
mainViewModel.markStartupScreenShown();
startActivity(new Intent(this, StartupActivity.class));
Expand Down
31 changes: 8 additions & 23 deletions app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/main/MainViewModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package com.d4rk.androidtutorials.java.ui.screens.main;

import android.app.Application;
import android.content.Intent;
import android.content.pm.PackageManager;

import androidx.lifecycle.ViewModel;
import androidx.lifecycle.LiveData;
Expand Down Expand Up @@ -31,7 +29,6 @@
@HiltViewModel
public class MainViewModel extends ViewModel {

private final Application application;
private final ApplyThemeSettingsUseCase applyThemeSettingsUseCase;
private final GetBottomNavLabelVisibilityUseCase getBottomNavLabelVisibilityUseCase;
private final GetDefaultTabPreferenceUseCase getDefaultTabPreferenceUseCase;
Expand All @@ -46,8 +43,7 @@ public class MainViewModel extends ViewModel {
private final MutableLiveData<Boolean> themeChanged = new MutableLiveData<>();

@Inject
public MainViewModel(Application application,
ApplyThemeSettingsUseCase applyThemeSettingsUseCase,
public MainViewModel(ApplyThemeSettingsUseCase applyThemeSettingsUseCase,
GetBottomNavLabelVisibilityUseCase getBottomNavLabelVisibilityUseCase,
GetDefaultTabPreferenceUseCase getDefaultTabPreferenceUseCase,
ApplyLanguageSettingsUseCase applyLanguageSettingsUseCase,
Expand All @@ -56,7 +52,6 @@ public MainViewModel(Application application,
IsAppInstalledUseCase isAppInstalledUseCase,
BuildShortcutIntentUseCase buildShortcutIntentUseCase,
GetAppUpdateManagerUseCase getAppUpdateManagerUseCase) {
this.application = application;
this.applyThemeSettingsUseCase = applyThemeSettingsUseCase;
this.getBottomNavLabelVisibilityUseCase = getBottomNavLabelVisibilityUseCase;
this.getDefaultTabPreferenceUseCase = getDefaultTabPreferenceUseCase;
Expand Down Expand Up @@ -84,26 +79,17 @@ private static int getVisibilityMode(String labelVisibilityStr, String[] bottomN
* Loads and applies settings such as theme, bottom nav visibility, default tab, etc.
* This can be called from onCreate() or similar lifecycle methods in MainActivity.
*/
public void applySettings() {
boolean changedTheme = applyThemeSettingsUseCase.invoke(
application.getResources().getStringArray(R.array.preference_theme_values)
);
public void applySettings(String[] themeValues,
String[] bottomNavBarLabelsValues,
String[] defaultTabValues) {
boolean changedTheme = applyThemeSettingsUseCase.invoke(themeValues);
themeChanged.setValue(changedTheme);

String labelKey = application.getString(R.string.key_bottom_navigation_bar_labels);
String labelDefaultValue = application.getString(R.string.default_value_bottom_navigation_bar_labels);
String[] bottomNavBarLabelsValues =
application.getResources().getStringArray(R.array.preference_bottom_navigation_bar_labels_values);

String labelVisibilityStr = getBottomNavLabelVisibilityUseCase.invoke(labelKey, labelDefaultValue);
String labelVisibilityStr = getBottomNavLabelVisibilityUseCase.invoke();
int visibilityMode = getVisibilityMode(labelVisibilityStr, bottomNavBarLabelsValues);
bottomNavLabelVisibility.setValue(visibilityMode);

String defaultTabKey = application.getString(R.string.key_default_tab);
String defaultTabValue = application.getString(R.string.default_value_tab);
String[] defaultTabValues = application.getResources().getStringArray(R.array.preference_default_tab_values);

String startFragmentIdValue = getDefaultTabPreferenceUseCase.invoke(defaultTabKey, defaultTabValue);
String startFragmentIdValue = getDefaultTabPreferenceUseCase.invoke();
int startFragmentId;
if (startFragmentIdValue.equals(defaultTabValues[0])) {
startFragmentId = R.id.navigation_home;
Expand Down Expand Up @@ -136,8 +122,7 @@ public void markStartupScreenShown() {
* Check if the “Android Tutorials” app is installed or not.
*/
public boolean isAndroidTutorialsInstalled() {
PackageManager pm = application.getPackageManager();
return isAppInstalledUseCase.invoke(pm, "com.d4rk.androidtutorials.java");
return isAppInstalledUseCase.invoke("com.d4rk.androidtutorials.java");
}

/**
Expand Down