[6.2.x] Strip redundant wrapped post-time listener checks #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimisation strips out some field reads and null checks for each listener at post-time when the event is final, not annotated with
@Cancelableand not a subclass ofGenericEvent, instead doing these checks at registration time.To help reduce the risk of megamorphic calls negating this optimisation, the stripping does not apply for
receiveCanceledlisteners on@Cancelableevents.This is somewhat similar to EventBus 7's handling of cancellable vs non-cancellable events, but much more basic as it has no knowledge of the other listeners on the ListenerList and needs to maintain backwards-compatibility with existing behaviour (such as your listener not being called when the subclass of the event type you're listening to is cancellable but not the event type itself), among other things such as not being able to account for the sealed class hierarchy of events due to targeting Java 16.
Draft pending more comprehensive benchmarksBenchmarks
Before
After