Skip to content

Add fittable #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 64 commits into from
Feb 7, 2025
Merged

Add fittable #140

merged 64 commits into from
Feb 7, 2025

Conversation

@stephantul
Copy link
Contributor

@stephantul stephantul commented Dec 23, 2024

No description provided.

@codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.41379% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
model2vec/inference/model.py 88.57% 8 Missing ⚠️
model2vec/train/classifier.py 97.40% 4 Missing ⚠️
Files with missing lines Coverage Δ
model2vec/hf_utils.py 69.56% <100.00%> (+1.08%) ⬆️
model2vec/inference/__init__.py 100.00% <100.00%> (ø)
model2vec/model.py 94.55% <100.00%> (ø)
model2vec/train/__init__.py 100.00% <100.00%> (ø)
model2vec/train/base.py 100.00% <100.00%> (ø)
model2vec/utils.py 92.53% <ø> (ø)
tests/conftest.py 100.00% <100.00%> (ø)
tests/test_inference.py 100.00% <100.00%> (ø)
tests/test_trainable.py 100.00% <100.00%> (ø)
model2vec/train/classifier.py 97.40% <97.40%> (ø)
... and 1 more

@stephantul stephantul marked this pull request as ready for review January 3, 2025 20:22
@stephantul stephantul requested a review from Pringled January 3, 2025 20:22
Pringled
Pringled requested changes Jan 4, 2025
View reviewed changes
Copy link
Member

@Pringled Pringled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some minor comments and suggestions.

@stephantul stephantul requested a review from Pringled January 24, 2025 18:49
davidberenstein1957
davidberenstein1957 reviewed Jan 26, 2025
View reviewed changes
Copy link
Contributor

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super useful. left some comments. Also, perhaps we can add some reference to multi-label usage somewhere?

Pringled
Pringled requested changes Feb 7, 2025
View reviewed changes
Copy link
Member

@Pringled Pringled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments and suggestions

stephantul and others added 7 commits February 7, 2025 20:07
@stephantul @Pringled
Update model2vec/inference/README.md
759b96c 
Co-authored-by: Thomas van Dongen <thomas123@live.nl>
@stephantul @Pringled
Update model2vec/inference/README.md
7caf9bc 
Co-authored-by: Thomas van Dongen <thomas123@live.nl>
@stephantul @Pringled
Update model2vec/inference/README.md
c7b68b6 
Co-authored-by: Thomas van Dongen <thomas123@live.nl>
@stephantul @Pringled
Update model2vec/train/classifier.py
be7baa1 
Co-authored-by: Thomas van Dongen <thomas123@live.nl>
@stephantul
fix: encode args
cc74618
@stephantul
fix: trust_remote_code
a4d8d6c
@stephantul
fix notebook
a0d56d5
@stephantul stephantul requested a review from Pringled February 7, 2025 19:23
Pringled
Pringled approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@Pringled Pringled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@stephantul stephantul merged commit a2da2e9 into main Feb 7, 2025
6 checks passed
@stephantul stephantul deleted the add-fittable branch February 7, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pringled Pringled Pringled approved these changes

+1 more reviewer

@davidberenstein1957 davidberenstein1957 davidberenstein1957 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stephantul @Pringled @davidberenstein1957