Skip to content

feat: Updated save_pretrained to save sentence-transformers compatible models #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 21, 2025
Merged

feat: Updated save_pretrained to save sentence-transformers compatible models #154

merged 7 commits into from
Jan 21, 2025

Conversation

@Pringled
Copy link
Member

@Pringled Pringled commented Jan 21, 2025

No description provided.

@Pringled Pringled requested a review from stephantul January 21, 2025 19:49
@codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
model2vec/hf_utils.py 80.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
tests/test_model.py 97.70% <100.00%> (+0.01%) ⬆️
model2vec/hf_utils.py 68.81% <80.00%> (+0.27%) ⬆️

stephantul
stephantul approved these changes Jan 21, 2025
View reviewed changes
@Pringled Pringled merged commit 14176b2 into main Jan 21, 2025
5 checks passed
@Pringled Pringled deleted the update-save-pretrained branch January 21, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stephantul stephantul stephantul approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pringled @stephantul