Number.isNaN update #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appears that this breaks compatibility too, though im not sure how. i might need to look more into isNaN but it seemed like all the inputs had been coerced before being passed to Number.isNaN edit: nevermind, its something wrong with my local copy of mw |
|
these changes appear to break nothing and give free performance |
|
triple equals should be faster on other browsers like firefox, no point in not using it there when you know it has to be a number or NaN |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to jsexecute about isNaN
#1
Ive replaced the values but it doesnt appear to make much of a noticable difference in performance on https://github.com/Its-Jakey/Linux-On-Scratch/blob/main/rv32ima.sb3
i decided to use linux on scratch because it was mentioned by garbo under this same topic, however ive not seen much change on its boot times