Gh 77 create process hook #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump directory upper bound to < 1.4
a9a8e91 added some `close` calls which attempted to close pipes that we already closed previously. This resulted in the error code we read from the failed child being overwritten, resulting in the `process004` test failing.
Don't close already closed pipes
Mistuke
force-pushed
the
gh-77-create-process-hook
branch
from
f5027af to
03d5d37
Compare
Mistuke
force-pushed
the
gh-77-create-process-hook
branch
2 times, most recently
from
f5027af to
c4d9a7a
Compare
Relax Win32 version bounds.
Clarify Binary properties of the streams
Mistuke
force-pushed
the
gh-77-create-process-hook
branch
from
129dd48 to
f8b53d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.