Skip to content

Conversation

@pennig
Copy link
Contributor

@pennig pennig commented Jul 15, 2023

Useful for operating on per-module index stores. To wit, an unused import B in module A will only be marked as unused if the tool can collect the units from A and the USRs from B.

@pennig pennig marked this pull request as draft July 15, 2023 13:43
@pennig pennig marked this pull request as ready for review July 15, 2023 13:43
@pennig
Copy link
Contributor Author

pennig commented Jul 15, 2023

CLA is signed

Copy link
Member

@keith keith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks!

@keith
Copy link
Member

keith commented Jul 17, 2023

you'll have to rebase on #51 shortly

@pennig pennig force-pushed the unused-imports_multiple-index-stores branch from f6f0289 to 56473d9 Compare July 20, 2023 16:11
@pennig pennig requested a review from keith July 20, 2023 16:12
@keith keith merged commit 9c89147 into MobileNativeFoundation:main Jul 20, 2023
@keith
Copy link
Member

keith commented Jul 20, 2023

thanks!

@pennig pennig deleted the unused-imports_multiple-index-stores branch July 20, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants