Move shard type loading to datapacks #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Also fix some stuff we missed in porting to 1.20.4 |
falkreon
reviewed
Jan 5, 2024
| FabricLoader.getInstance().getModContainer(ID).ifPresent(mod -> { | ||
| ResourceManagerHelper.registerBuiltinResourcePack(ScatteredShards.id("test"), mod, ResourcePackActivationType.NORMAL); | ||
| ResourceManagerHelper.registerBuiltinResourcePack(ScatteredShards.id("bc23-assets"), mod, ResourcePackActivationType.NORMAL); | ||
| ResourceManagerHelper.registerBuiltinResourcePack(ScatteredShards.id("bc23-data"), mod, ResourcePackActivationType.NORMAL); |
Collaborator
There was a problem hiding this comment.
Synthetic respacks should be registered on the client side
falkreon
requested changes
Jan 5, 2024
Collaborator
falkreon
left a comment
falkreon
left a comment
There was a problem hiding this comment.
I definitely said in discord that there is an opportunity to load ShardTypes from data, but it needs to only happen for new worlds that have no ShardType data - otherwise data clobbers the (not-yet-extant) ingame editor, and that's no good. ShardTypeLoader should hold its own counsel about what the data-defined default types are, and only pour them into the server library if ShardLibraryPersistentState detects a fresh world / library and calls addDefaultShardTypes.
There are also quite a few extra diffs here that I don't understand the need for.
src/main/java/net/modfest/scatteredshards/api/impl/ShardLibraryPersistentState.java
Show resolved
Hide resolved
src/main/java/net/modfest/scatteredshards/client/ScatteredShardsClient.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For supporting usage over multiple events (see discussion in Discord)