fix(searchinput): clean up props#3080
Merged
hevele-moda merged 1 commit intomasterfrom Dec 1, 2022
Merged
Conversation
Removes the 'onChangeValue' callback, 'onChange' can be used instead. BREAKING CHANGE: removed 'onChangeValue'
✅ Deploy Preview for moda-om-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
|
we should check/ remove usage of this onChangeValue in discovery and where its used |
Contributor
Author
Yes, of course, this is a breaking change and all repos that use it might have to adjust. |
bjmiller
approved these changes
Dec 1, 2022
moda-automation-devops
pushed a commit
that referenced
this pull request
Dec 1, 2022
# [18.0.0](v17.14.2...v18.0.0) (2022-12-01) ### Bug Fixes * **searchinput:** clean up props ([#3080](#3080)) ([3f3f645](3f3f645)) ### BREAKING CHANGES * **searchinput:** removed 'onChangeValue'
|
🎉 This PR is included in version 18.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the 'onChangeValue' callback, 'onChange' can be used instead.
Also removes the
useEffectthat calledonChangeValue.Not confirmed, but this can be the source of a UI glitch that happens on the search bar intermittently.
ISSUES WORKED ON: ECOM-2215
BREAKING CHANGE: removed 'onChangeValue'