Fix input processing for convolution #1554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the previous support for convolution layers. In this PR, I’ve added fixes for two specific cases:
Conv1D and unfold parameter requirement:
The unfold operation expects 2D parameters, so for Conv1D layers, both the input tensor and parameters need to be expanded by one dimension to match the expected shape.
Grouped convolutions:
Fixed the input tensor shape for convolutions that use the groups parameter to ensure the input is correctly formatted and grouped during computation.
ref:
https://pytorch.org/docs/stable/generated/torch.nn.Unfold.html
https://discuss.pytorch.org/t/conv1d-implementation-using-torch-nn-functional-unfold/109643/3