fix exception to avoid memory issue #1679
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception
eis not just an ImportError instance — it also stores a reference to a traceback object.The traceback contains the entire call stack at the time of the error.
Keeping the exception as a global value will lead to the object not being released, for example:
Output before this PR:
We can keep the string of the exception instead of the exception object. In this case, we only store a string instead of the full traceback as the global value.
Output after this PR: