Skip to content

Fix triton version detection in nogil patcher #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

Fix triton version detection in nogil patcher #2144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions gptqmodel/utils/nogil_patcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,14 @@
import time

from .safe import ThreadSafe
from importlib.metadata import version
from packaging.version import Version, InvalidVersion


_PATCHED_ATTR = "_gptqmodel_locked_save_file"

TRITON_MIN_VERSION_STR = "3.5.0"


def patch_safetensors_save_file() -> None:
try:
Expand All @@ -38,9 +42,16 @@ def patch_triton_autotuner() -> None:
except ImportError:
return

version = getattr(triton, "__version__", None)
if version is None or tuple(int(part) for part in version.split(".")[:3]) < (3, 5, 0):
return
triton_version_str = version("triton")

try:
triton_ver = Version(triton_version_str)
triton_min_version = Version(TRITON_MIN_VERSION_STR)
if triton_ver < triton_min_version:
return
except InvalidVersion:
if triton_version_str < TRITON_MIN_VERSION_STR:
return

autotuner_cls = module.Autotuner
if getattr(autotuner_cls, "_gptqmodel_threadsafe", False):
Expand Down
Loading