Skip to content

Conversation

@RonnyChan96
Copy link
Contributor

  • Add special case handling for keys.length === 1 scenarios
  • Skip parent config lookup when updating root-level configurations
  • Prevent unnecessary null checks for single-key updates
  • Maintain existing multi-key update logic unchanged

Key improvements:

  1. Behavior change:

    • Before: Would throw when parentConfig is null for single-key paths
    • Now: Directly updates config without parent lookup for single-key
  2. Performance benefit:

    • Eliminates redundant slice(0,-1) operation for single-key cases
    • Avoids unnecessary parent config existence check
  3. Safety:

    • Still validates empty keys array (unchanged)
    • Preserves all existing error handling for multi-key paths

@RonnyChan96 RonnyChan96 self-assigned this May 16, 2025
@RonnyChan96 RonnyChan96 requested review from a team, CodeCasterX, Msquittto and wjn1584 May 16, 2025 04:25
@RonnyChan96 RonnyChan96 added type: bug A general bug in: elsa Issues in Elsa modules labels May 16, 2025
@CodeCasterX CodeCasterX added this to Nova May 16, 2025
@CodeCasterX CodeCasterX added this to the elsa 0.1.x milestone May 16, 2025
@CodeCasterX CodeCasterX merged commit c487977 into ModelEngine-Group:elsa-0.1.x May 16, 2025
1 check passed
@github-project-automation github-project-automation bot moved this to Done in Nova May 16, 2025
@CodeCasterX CodeCasterX modified the milestones: elsa 0.1.x, elsa 0.1.1 May 19, 2025
Yager-42 pushed a commit to Yager-42/fit-framework that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: elsa Issues in Elsa modules type: bug A general bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants