Skip to content

fix(ConnectorProvider): Sync connector name changes with connected lines (fixes #41) #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

fix(ConnectorProvider): Sync connector name changes with connected lines (fixes #41) #132

merged 1 commit into from
May 20, 2025

Conversation

@RonnyChan96
Copy link
Contributor

@RonnyChan96 RonnyChan96 commented May 17, 2025

Fixes an issue where renaming a ConnectorProvider would break connected lines:

  • Added prevNameRef to detect name changes
  • Auto-updates direction.key and line references
  • Preserves existing connections

Test:

  1. Change a connector's name
  2. Verify lines remain connected and references update

@RonnyChan96
Copy link
Contributor Author

RonnyChan96 commented May 17, 2025

@CodeCasterX 请关联#41

@RonnyChan96 RonnyChan96 changed the title fix(ConnectorProvider): Sync connector name changes with connected lines (fixes #41) fix(ConnectorProvider): Sync connector name changes with connected lines (fixes https://github.com/ModelEngine-Group/fit-framework/issues/41) May 17, 2025
@RonnyChan96 RonnyChan96 changed the title fix(ConnectorProvider): Sync connector name changes with connected lines (fixes https://github.com/ModelEngine-Group/fit-framework/issues/41) fix(ConnectorProvider): Sync connector name changes with connected lines (fixes #41) May 17, 2025
@RonnyChan96 RonnyChan96 self-assigned this May 17, 2025
@RonnyChan96 RonnyChan96 requested review from a team, CodeCasterX and wjn1584 May 17, 2025 08:13
@RonnyChan96 RonnyChan96 added type: bug A general bug in: elsa Issues in Elsa modules labels May 17, 2025
@CodeCasterX CodeCasterX added this to Nova May 18, 2025
@CodeCasterX CodeCasterX modified the milestones: 3.5.0, elsa 0.1.x, elsa 0.2.0 May 18, 2025
@CodeCasterX CodeCasterX linked an issue May 18, 2025 that may be closed by this pull request
条件节点多分支连线后，删除分支再添加分支，重新运行会出现运行结果错乱的情况 #41
Closed
@CodeCasterX CodeCasterX added this to the elsa 0.1.2 milestone May 19, 2025
@CodeCasterX CodeCasterX merged commit 5be0e6b into ModelEngine-Group:elsa-0.1.x May 20, 2025
1 check passed
@github-project-automation github-project-automation bot moved this to Done in Nova May 20, 2025
Yager-42 pushed a commit to Yager-42/fit-framework that referenced this pull request Aug 16, 2025
@RonnyChan96
[elsa] fix(ConnectorProvider): sync connector name with related lines (…
aa6ff20 
…ModelEngine-Group#132)
surpercodehang pushed a commit that referenced this pull request Oct 10, 2025
@RonnyChan96 @surpercodehang
[elsa] fix(ConnectorProvider): sync connector name with related lines (…
d4b0030 
…#132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjn1584 wjn1584 wjn1584 approved these changes

@CodeCasterX CodeCasterX Awaiting requested review from CodeCasterX

Assignees

@RonnyChan96 RonnyChan96

Labels

in: elsa Issues in Elsa modules type: bug A general bug

Projects

Nova
Status: Done

Milestone

elsa 0.1.2

Development

Successfully merging this pull request may close these issues.

条件节点多分支连线后，删除分支再添加分支，重新运行会出现运行结果错乱的情况

3 participants

@RonnyChan96 @wjn1584 @CodeCasterX