Skip to content

Conversation

@RonnyChan96
Copy link
Contributor

This PR fixes an issue in JadeReferenceTreeSelect where reference updates were being skipped when selecting the same value, particularly affecting cross-application node copying scenarios.

Problem
Previously, when:

  1. Copying nodes between applications
  2. Selecting the same reference value again
    The component would skip updates if selected === reference.referenceId, leading to:
  • Stale referenceKey and value values
  • Broken references in cross-application copies

Solution
Key changes:

  1. Removed duplicate selection check that prevented updates
  2. Now always triggers onReferencedKeyChange on selection
  3. Ensures referenceKey and value stay synchronized

@RonnyChan96 RonnyChan96 requested review from a team, CodeCasterX and wjn1584 May 20, 2025 09:09
@RonnyChan96 RonnyChan96 self-assigned this May 20, 2025
@RonnyChan96 RonnyChan96 added type: bug A general bug in: elsa Issues in Elsa modules labels May 20, 2025
@CodeCasterX CodeCasterX added this to Nova May 20, 2025
@CodeCasterX CodeCasterX added this to the elsa 0.1.2 milestone May 20, 2025
@CodeCasterX CodeCasterX merged commit 364a7e8 into ModelEngine-Group:elsa-0.1.x May 20, 2025
1 check passed
@github-project-automation github-project-automation bot moved this to Done in Nova May 20, 2025
Yager-42 pushed a commit to Yager-42/fit-framework that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: elsa Issues in Elsa modules type: bug A general bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants