Skip to content

[fit] Implement parameter validation plugins that supports both javax and Jakarta standards #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Aug 20, 2025
Merged

[fit] Implement parameter validation plugins that supports both javax and Jakarta standards #251

merged 23 commits into from
Aug 20, 2025

Conversation

@Yager-42
Copy link
Contributor

@Yager-42 Yager-42 commented Aug 16, 2025

🔗 相关问题 / Related Issue

Issue 链接 / Issue Link: #77

📋 变更类型 / Type of Change

  • 🐛 Bug 修复 / Bug fix (non-breaking change which fixes an issue)
  • ✨ 新功能 / New feature (non-breaking change which adds functionality)
  • 💥 破坏性变更 / Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 文档更新 / Documentation update
  • 🔧 重构 / Refactoring (no functional changes)
  • ⚡ 性能优化 / Performance improvement
  • 🧹 代码清理 / Code cleanup

📝 变更目的 / Purpose of the Change

为FIT提供校验javax validation和Jakarta validation标准注解的功能，当前项目仅能对javax validation注解进行校验

📋 主要变更 / Brief Changelog

  • 新增了两个插件，分别对javax validation和Jakarta validation标准注解进行校验

🧪 验证变更 / Verifying this Change

测试步骤 / Test Steps

  1. 单元测试
  2. 手动进行fit start 测试

测试覆盖 / Test Coverage

  • 我已经添加了单元测试 / I have added unit tests
  • 所有现有测试都通过 / All existing tests pass
  • 我已经进行了手动测试 / I have performed manual testing

📸 截图 / Screenshots

image

✅ 贡献者检查清单 / Contributor Checklist

请确保你的 Pull Request 符合以下要求 / Please ensure your Pull Request meets the following requirements:

基本要求 / Basic Requirements:

  • 确保有 GitHub Issue 对应这个变更（微小变更如错别字除外）/ Make sure there is a Github issue filed for the change (trivial changes like typos excluded)
  • 你的 Pull Request 只解决一个 Issue，没有包含其他不相关的变更 / Your PR addresses just this issue, without pulling in other changes - one PR resolves one issue
  • PR 中的每个 commit 都有有意义的主题行和描述 / Each commit in the PR has a meaningful subject line and body

代码质量 / Code Quality:

  • 我的代码遵循项目的代码规范 / My code follows the project's coding standards
  • 我已经进行了自我代码审查 / I have performed a self-review of my code
  • 我已经为复杂的代码添加了必要的注释 / I have commented my code, particularly in hard-to-understand areas

测试要求 / Testing Requirements:

  • 我已经编写了必要的单元测试来验证逻辑正确性 / I have written necessary unit-tests to verify the logic correction
  • [] 当存在跨模块依赖时，我尽量使用了 mock / I have used mocks when cross-module dependencies exist
  • [] 基础检查通过：mvn -B clean package -Dmaven.test.skip=true，elsa README 中的编译检查 / Basic checks pass
  • 单元测试通过：mvn clean install / Unit tests pass

文档和兼容性 / Documentation and Compatibility:

  • 我已经更新了相应的文档 / I have made corresponding changes to the documentation
  • 如果有破坏性变更，我已经在 PR 描述中详细说明 / If there are breaking changes, I have documented them in detail
  • 我已经考虑了向后兼容性 / I have considered backward compatibility

📋 附加信息 / Additional Notes

当前FIT中没有提供完整的国际化实现，无法通过request，cookie或session等方式获取访问者的地区并返回地区对应的内容

审查者注意事项 / Reviewer Notes:

@Yager-42 Yager-42 changed the title [fit] 实现参数校验插件，支持javax，Jakarta标准 [fit] Implement parameter validation plugins that supports both javax and Jakarta standards Aug 16, 2025
@CodeCasterX CodeCasterX linked an issue Aug 16, 2025 that may be closed by this pull request
支持 Jakarta Validation #77
Closed
@CodeCasterX CodeCasterX added type: enhancement A general enhancement in: fit Issues in FIT modules labels Aug 16, 2025
@CodeCasterX CodeCasterX modified the milestones: 3.5.0, 3.6.0 Aug 16, 2025
CodeCasterX
CodeCasterX reviewed Aug 16, 2025
View reviewed changes
@CodeCasterX CodeCasterX merged commit 5a1e250 into ModelEngine-Group:main Aug 20, 2025
1 check passed
surpercodehang pushed a commit that referenced this pull request Oct 10, 2025
@Yager-42 @CodeCasterX @surpercodehang
[fit] Implement parameter validation plugins that supports both javax…
2c242bf 
… and Jakarta standards (#251)

* [fit] 实现参数校验插件，支持javax，Jakarta标准

* [fit] 实现参数校验插件，支持javax，Jakarta标准

* [fit] 修改不当的标准判断方式，提供校验插件使用指南

* [fit] 将handler修改为责任链形式

* [fit] 修改插件优先级

* [fit] 删除旧的校验实现及其文档说明

* [fit] 修改校验插件包名

* [fit] 完善注释和代码规范

* [fit] 处理格式

* [fit] 处理格式，注释和文档

* [fit] 完善文档和注释

* [fit] 完善文档

* [fit] 修改测试实现，强制测试的语言，完善注释

* [fit] 完善格式

* [fit] 完善注释

* [fit] 实现可显式传递地区的校验处理

* [fit] 完善注释

* [fit] 完善注释

* [fit] 完善注释

* polish code

* Add dependency

* [fit] 修改消息插值器代理中错误的locale设置方式

* [fit] 完善注释

---------

Co-authored-by: jiyujie <jiyujie880621@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CodeCasterX CodeCasterX CodeCasterX approved these changes

Assignees

@Yager-42 Yager-42

Labels

in: fit Issues in FIT modules type: enhancement A general enhancement

Projects

OSPP 2025
Status: Done

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

支持 Jakarta Validation

2 participants

@Yager-42 @CodeCasterX