-
Notifications
You must be signed in to change notification settings - Fork 418
🐛 Bug fix: users can not start new conversation when memory is still adding. #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| asyncio.create_task(_add_memory_background()) | ||
| except Exception as schedule_err: | ||
| logger.error( | ||
| f"Failed to schedule background memory addition: {schedule_err}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个方法流程有点长了,建议拆分几个子函数
| agent_id, | ||
| top_k, | ||
| threshold, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
函数传参较多,建议封装为对象。
…adding. 🐛 Bug fix: memory won't generate in agent debug mode ✨ Memory add/update/search in different levels are now all async ✨ Memory add/update success now displays a red dot in the upper right corner of memory button as an indicator ♻️ Remove redundant parse of authorization
26220f9 to
230f753
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
d845268 to
a991564
Compare
a991564 to
113b9d1
Compare
🐛 Bug fix: users can not start new conversation when memory is still adding.
🐛 Bug fix: memory won't generate in agent debug mode.
✨ Memory add/update/search in different levels are now all async.
✨ Memory add/update success now displays a red dot in the upper right corner of memory button as an indicator.
♻️ Remove redundant parse of authorization.
20250904_170126.mp4