Skip to content

🐛 Fix the issue where the frontend still throws an exception after successfully batch modifying the model configuration #1439 #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
Merged

🐛 Fix the issue where the frontend still throws an exception after successfully batch modifying the model configuration #1439 #1567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32b4983
🐛 Fix the issue where the frontend still throws an exception after su…
YehongPan Nov 5, 2025
03c7e57
🐛 Fix the issue where the frontend still throws an exception after su…
YehongPan Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions frontend/app/[locale]/setup/models/components/model/ModelDeleteDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,15 +453,12 @@ export const ModelDeleteDialog = ({
maxTokens: maxTokens || m.maxTokens,
}));

const result = await modelService.updateBatchModel(
await modelService.updateBatchModel(
currentModelPayloads
);

if (result.code !== 200) {
message.error(t("model.dialog.error.noModelsFetched"));
} else {
message.success(t("model.dialog.success.updateSuccess"));
}
// Show success message since no exception was thrown
message.success(t("model.dialog.success.updateSuccess"));

// Optionally use currentModelPayloads for subsequent API calls if needed
} catch (e) {
Expand Down
2 changes: 1 addition & 1 deletion frontend/public/locales/en/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@
"model.dialog.error.connectivityRequired": "Please verify model connectivity and ensure connection is successful before adding the model",
"model.dialog.error.addFailed": "Failed to add model",
"model.dialog.error.addFailedLog": "Failed to add model",
"model.dialog.error.noModelsFetched": "Please check your API key and network connectivity",
"model.dialog.error.noModelsFetched": "Operation failed! Please check your API key and network connectivity",
"model.dialog.message.noModels": "Please fetch models first",
"model.dialog.success.updateSuccess": "Updated successfully",
"model.dialog.editTitle": "Edit Model",
Expand Down
2 changes: 1 addition & 1 deletion frontend/public/locales/zh/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@
"model.dialog.error.connectivityRequired": "请先验证模型连通性且确保连接成功后再添加模型",
"model.dialog.error.addFailed": "添加模型失败",
"model.dialog.error.addFailedLog": "添加模型失败",
"model.dialog.error.noModelsFetched": "请检查相关API Key以及网络连通性",
"model.dialog.error.noModelsFetched": "操作失败！请检查相关API Key以及网络连通性",
"model.dialog.message.noModels": "请先获取模型",
"model.dialog.editTitle": "编辑模型",
"model.dialog.editSuccess": "模型更新成功",
Expand Down