[Feature]: pluggable SpaceLayout to avoid in-place rename for better performance on PCFS #299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In the default design, a Block file has two states:
The state is encoded in the file name and switched by an in-directory rename.
On some storage systems (e.g. PCFS) this rename is expensive.
This PR introduces an optional layout that keeps the two states in separate directories so the switch becomes a fast cross-directory move.
Modifications
SpaceLayoutinto an interfaceSpaceShardLayout(state encoded in file name, activated & archived live in the same directory)SpaceShardTempLayout; whentempDumpDirEnable=trueactivated files are written to a temporary directory and moved to the final directory on completionTest