fix prefill classed mode.

[hiworldwzj]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @hiworldwzj, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a fix for the 'prefill classed mode' by introducing a new boolean flag, classed_req_strict_prefill, initialized to False. This flag is added to the initialization logic of both the chunked prefill and data-parallel backend implementations, suggesting it will be used to manage or toggle specific behaviors related to prefill requests within these modes.

Highlights

• New Configuration Flag: Introduced a new instance variable self.classed_req_strict_prefill and initialized it to False within the __init__ methods of both chunked_prefill/impl.py and dp_backend/impl.py.
• Prefill Classed Mode Fix: This change addresses a fix for the 'prefill classed mode' by adding a new configuration flag, likely to control specific prefill behavior or state.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes an issue with how prefill requests are classified in ChunkedPrefillBackend and DPChunkedPrefillBackend. By overriding classed_req_strict_prefill to False, it ensures that requests ready for their first token generation are properly handled as decode requests. My review includes suggestions to add comments explaining this override, which will improve code clarity and long-term maintainability.

[gemini-code-assist]

While this change is correct, the reason for overriding the base class's classed_req_strict_prefill from True to False is not immediately obvious. Adding a comment to explain this logic would significantly improve code clarity and maintainability for future developers.

Suggested change

	self.classed_req_strict_prefill = False
	# Override base class setting. For chunked prefill, a request that has
	# finished prefilling the prompt and is ready for the first token generation
	# should be classified as a decode request, not a prefill one.
	self.classed_req_strict_prefill = False

[gemini-code-assist]

This override is also correct for the DPChunkedPrefillBackend. To maintain consistency and improve readability, please consider adding a comment here as well, explaining why this backend requires classed_req_strict_prefill to be False.

Suggested change

	self.classed_req_strict_prefill = False
	# Override base class setting. For this backend, a request that has
	# finished prefilling the prompt and is ready for the first token generation
	# should be classified as a decode request, not a prefill one.
	self.classed_req_strict_prefill = False