Integrate Gauntlt #33
Conversation
obscurerichard
left a comment
obscurerichard
left a comment
There was a problem hiding this comment.
@rpigu-i can you fix up the issue listed? I got the build passing again in Jenkins.
Vagrantfile
Outdated
| config.vm.synced_folder ".", "/app" | ||
| config.vm.provision "shell", inline: "/app/bin/install-ansible.sh", upload_path: "/home/vagrant/install-ansible.sh" | ||
| config.vm.provision "shell", inline: "cd /app/ansible && ansible-playbook -l localhost bakery.yml app-AfterInstall.yml app-StartServer.yml", upload_path: "/home/vagrant/apl.sh" | ||
| config.vm.provision "shell", inline: "curl -sSL https://rvm.io/mpapis.asc | gpg2 --import -" |
There was a problem hiding this comment.
Ugh, don't do it like this, create a proper bin/install-gauntlt.sh script instead.
There was a problem hiding this comment.
Nevermind, I already did that in the PR I just merged in here. I forgot I even worked on this!
There was a problem hiding this comment.
Yeah, this was done a while back (I think you did that around the time we did the demo). Is this now a dead PR, or does this still need to be merged into master and need a review?
Thanks
There was a problem hiding this comment.
This PR, #33 is still live and needs to get into master. It LGTM now, were you ready with this work and where it was or is there more to add before we merge it?
I haven't tested this integration at all yet either.
There was a problem hiding this comment.
Consider where we would want to put these tests if we are running in CI, not just in Vagrant, too @rpigu-i
…nd-readme Refactor Vagrant scripts and readme for gauntlt
Also fix up rvm and bash script options
…actor Put in root checks, refactor functions
Run Gauntlt through packer
|
This is working nicely now. Here's a screenshot of the report from Jenkins (see PR-33 build 12).
Here's a screenshot of the New Relic note capturing this test run:
|
No description provided.