Skip to content

fix resolution of vulnerable semver package #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2018
Merged

fix resolution of vulnerable semver package #2

merged 1 commit into from
May 2, 2018

Conversation

@grgur
Copy link
Member

@grgur grgur commented May 2, 2018

  • Added resolutions in package.json
  • removed package-lock.json in favor of yarn.lock because yarn follows resolutions to override nested dependencies

@grgur grgur requested a review from AhsanAyaz May 2, 2018 13:00
AhsanAyaz
AhsanAyaz approved these changes May 2, 2018
View reviewed changes
Copy link
Contributor

@AhsanAyaz AhsanAyaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@grgur grgur merged commit dece753 into master May 2, 2018
@grgur grgur deleted the fix/semver branch May 2, 2018 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AhsanAyaz AhsanAyaz AhsanAyaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grgur @AhsanAyaz