Skip to content

Conversation

@Keyyard
Copy link
Contributor

@Keyyard Keyyard commented Aug 22, 2025

this PR changed how copyFiles works by adding a filter for destination file size checking, by this when we compile it will save much more time of copying the same things again.

@JakeShirley
Copy link
Contributor

I will queue this up for some team discussions next week @Keyyard, thanks a ton for the PR :)

@Keyyard
Copy link
Contributor Author

Keyyard commented Aug 23, 2025

hey, i know this is kinda off topic, but i made a npm package to help developers get started with add-on creations within a minute. I wonder if i can show you here? I have made a website for it as well.

Let me just attach it here just in case, this is a big pleasure of mine to having you seen it!

Website Github NPM

@Keyyard Keyyard requested a review from JakeShirley August 27, 2025 12:43
Copy link
Collaborator

@rlandav rlandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change. You'll also need to add a change file by running npm run change. I think this should be a minor bump.

@Keyyard
Copy link
Contributor Author

Keyyard commented Sep 7, 2025

I have done the flagging & bumped using npm run change. Thank you all so much!

@Keyyard Keyyard requested a review from rlandav September 7, 2025 14:34
@rlandav
Copy link
Collaborator

rlandav commented Sep 9, 2025

I have done the flagging & bumped using npm run change. Thank you all so much!

Just FYI you'll need to resolve build issues.

@Keyyard
Copy link
Contributor Author

Keyyard commented Sep 10, 2025

I have done the flagging & bumped using npm run change. Thank you all so much!

Just FYI you'll need to resolve build issues.

I have gotten all the tests passed and build successfully! My pleasure to be on a part of the work, thank you all so much. <3

@rlandav
Copy link
Collaborator

rlandav commented Sep 10, 2025

Merging, thanks for the contribution!

@rlandav rlandav merged commit 70f1d4d into Mojang:main Sep 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants