-
Notifications
You must be signed in to change notification settings - Fork 13
feat(copyFiles): improve with size filter #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I will queue this up for some team discussions next week @Keyyard, thanks a ton for the PR :) |
|
hey, i know this is kinda off topic, but i made a npm package to help developers get started with add-on creations within a minute. I wonder if i can show you here? I have made a website for it as well. Let me just attach it here just in case, this is a big pleasure of mine to having you seen it! |
rlandav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change. You'll also need to add a change file by running npm run change. I think this should be a minor bump.
|
I have done the flagging & bumped using |
Just FYI you'll need to resolve build issues. |
I have gotten all the tests passed and build successfully! My pleasure to be on a part of the work, thank you all so much. <3 |
|
Merging, thanks for the contribution! |
this PR changed how copyFiles works by adding a filter for destination file size checking, by this when we compile it will save much more time of copying the same things again.