Base document _mark_as_changed bug

[iici-gli]

At base/document.py line 496, the remove function is called on the list being loopped on. The loopped on list should be a shallow copy:
<--
for field in self._changed_fields:
if field.startswith(level):
remove(field)
-->
for field in self._changed_fields[:]:
if field.startswith(level):
remove(field)

[lafrech]

I just had a quick look and AFAIU, the point of the loop is to remove those fields from self._changed_fields, so it shouldn't be a copy. But I might be wrong.

In any case, could you please explain what is wrong in more details, provide an example of misbehaviour or even better a test that shows what your change fixes?

[iici-gli]

check this out:
https://unspecified.wordpress.com/2009/02/12/thou-shalt-not-modify-a-list-during-iteration/

[lafrech]

OK, I get it. Now I understand the remove = self._changed_fields.remove. Looks like the job was half-done already.

[wojcikstefan]

Fixed in ca415d5