Use SaveConditionError instead of OperationError in save_condition #1070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Working with
save_conditionin save, I realised using anOperationErrorexception is too vague when trying to return fine errors to client, example:I solve this by replacing the
OperationErrortriggered by an invalidsave_conditionby a newSaveConditionError(subclass ofOperationError, to mimic the behaviour ofNotUniqueError)