Allow sparse compound indexes #1114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gmacon can you please rebase? |
|
OK, rebased onto master. |
|
The CI build (https://travis-ci.org/MongoEngine/mongoengine/jobs/84813626) failed because it couldn't clone the repo, and I can't figure out how to make it try again. Can someone with more knowledge (or maybe just more permissions) kick it off again? |
|
Just did |
|
The Travis failure doesn't look related to this change. |
|
OK, rebased again. |
|
These changes still don't seem to be implicated in the Travis failure (though there's a real bug there, this time). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of MongoDB 2.6, sparse compound indexes are allowed: http://docs.mongodb.org/manual/core/index-sparse/#sparse-compound-indexes. This removes the explicit check prohibiting sparse compound indexes. Also, I added a unit test to make sure that sparse-compound indexes work.