Fixed not being able to run tests on Windows #1153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWhetter
force-pushed
the
fixWindowsTest
branch
from
5bf83b4 to
04e8b83
Compare
|
I'm already in the AUTHORS file but I've rebased and changed the changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows, pip needs the PYTHON_EGG_CACHE and windir environment variables to be able to install packages correctly. Therefore tox needs to pass these variables down to pip when tox installs packages locally.
PYTHON_EGG_CACHE is set to reside in the virtualenv directory so that it does not pollute a users global egg cache directory. Plus it may not be set by a user, even though I found it to be required for pip to run in virtualenv with tox.