EmbeddedDoc. prepare_query_value for None value #1163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If EmbeddedDocument is None on filter, Mongoengine was crashing.
There was a problem hiding this comment.
can't these two if statements be merged?
… parent. We had the following changes to an object: obj.something obj.data.rut obj.data._rut obj.data._dv Then a big change over the obj.data field was made, thus leaving changes like this: obj.something obj.data But instead we where getting: obj.something obj.data obj.data._rut Then the mongodb operation raised an error of the incompatible $set operation trying to change data._rut and data at the same time. Mongoengine had a bug because it was deleting elements on the list while iterating it. This fixes the issue copying the list, so we iterate over the copy while we remove elements on the original.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering field for None value on Embedded Document was casing Query to crash.
Something like:
MyModel.objects.filter(myembeddedfield = None)