fix delete cascade for models without literal `id` field #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

wojcikstefan merged 1 commit into MongoEngine:master from rmendocna:master

Dec 6, 2016

Contributor

rmendocna commented Mar 3, 2016

replace literal 'id__in' with 'pk__in'


          fix delete cascade for models without literal id field: replace wit…

f12744d

…h `pk`

Member

wojcikstefan commented Dec 6, 2016

given that pk should always be preferred above id, I'm comfortable merging it as-is. Thanks @rmendocna !

wojcikstefan merged commit 25e0f12 into MongoEngine:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet