Attempt to fix len iteration bug #1283
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation doesn't stop the iteration at the current page.
|
The problem was self._has_more checks the result_cache length, but we should be checking the full length of the entire queryset. So instead of StopIteration at ITER_CHUNK_SIZE we stop when we get to the end of the queryset. |
| queryset.rewind() | ||
| return queryset | ||
|
|
||
| def __len__(self): |
There was a problem hiding this comment.
Otherwise: TypeError: object of type 'QuerySetNoCache' has no len()
|
Also fixes bug where len() of QuerySetNoCache was failing. |
|
I tried to pull master, but there are no changes... not sure why it thinks there are merge conflicts? It merges locally fine with no conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1086
Also merged test from #1072 and passing.
This change is