Delete port from connection settings only if on pymongo 2 #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the port is dropped from connection settings even if `MongoReplicaSetClient` is not being used.
|
Thanks for this @szuliq! Could you elaborate on the issues this is causing if port is dropped for PyMongo 3+'s |
|
This is superseded by #1436 |
|
Sorry I didn't comment on this. Somehow I didn't notice it in my mailbox. TBH I don't remember right now. We've had some strange issue one time and I investigated it, found this bug and opened this PR. Good thing you've fixed it. Thanks! |
|
@szuliq hi, i do not know why port in MongoReplicaSetClient for pymongo 2.x was droped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the port is dropped from connection settings even if
MongoReplicaSetClientis not being used.This change is