Skip to content

Conversation

@wojcikstefan
Copy link
Member

@wojcikstefan wojcikstefan commented Jul 10, 2016

As discussed in #1021


This change is Reviewable

@wojcikstefan wojcikstefan changed the title Replace map-reduce-based QuerySet.sum/average with aggregation-based implementations Replace map-reduce based QuerySet.sum/average with aggregation-based implementations Jul 10, 2016
@wojcikstefan
Copy link
Member Author

@lafrech @thedrow take a look at this when you get a chance - it's what we discussed at the bottom of #1021. Also @thedrow let me know how/if I should make changes to the documentation.

@wojcikstefan
Copy link
Member Author

wojcikstefan commented Jul 11, 2016

@thedrow thanks for the tuple suggestion - good point.

Is this a breaking change? I don't think it is but we should highlight this in the changelog anyway.

It passes all the tests that the old code passed and right now I can't think of a scenario it wouldn't cover.

Anything else we should cover before merging this?

Edit: ah, the changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant