Support Falsey primary_keys
#1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OJFord
changed the title
primary_keys (closes #1352)primary_keys
|
@OJFord this looks good to me, but the tests are failing. Could you rebase against the latest master? |
This commit adds a test for the incorrect behaviour raised in #1352, in which updating a document with a `0` primary_key fails with: > OperationError: attempt to update a document not yet saved despite prior saving. The issue is almost certainly due to a failure to distinguish between `None` and other falsey values.
Closes #1352; in which updates to such a document would raise an exception as though it had never been saved.
|
@wojcikstefan Looks like the key difference is that the two targets that failed have been dropped (dd473d1); I've rebased anyway. |
|
Thank you @OJFord ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for creating and updating a document that has a
Falseyprimary_keyattribute, and fixes it by replacing Boolean-casting existential checks for non-casting checks forNoneType.Closes #1352.