Skip to content

Conversation

@BenCoDev
Copy link
Contributor

At Dictionary Fields description, it seems that the intent of the sentence make more sense by adding : "not".

At Dictionary Fields description, it seems that the intent of the sentence make more sense by adding : "not".
@BenCoDev
Copy link
Contributor Author

BenCoDev commented Nov 18, 2016

Yes, now that I reread it with your perspective, I see that it could go either way.

The sentence is :

"Often, an embedded document may be used instead of a dictionary – generally this is recommended as dictionaries don’t support validation or custom field types. However, sometimes you will not know the structure of what you want to store; in this situation a DictField is appropriate [...]"

We can just restate which one is implied by the "this":

"Often, an embedded document may be used instead of a dictionary – generally embedded documents are recommended as dictionaries don’t support validation or custom field types. However, sometimes you will not know the structure of what you want to store; in this situation a DictField is appropriate [...]"

What do you think, it clarifies the notion I think,

Update dict fields use misleading description to clarify use case.
@BenCoDev
Copy link
Contributor Author

Thx @thedrow, I edited and rebased.

@thedrow thedrow merged commit 0a20e04 into MongoEngine:master Nov 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant