Clean up field unit tests #1498
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ephraimberkovitch fyi you pointed out in #1485 (comment) that many tests follow an invalid pattern. This PR is an attempt at cleaning some of it up. Feel free to submit similar patches for other parts of the codebase!
High level summary of the changes:
drop_collectioncalls (we only need those in the beginning of a test).CachedReferenceFieldinto a separate test class (makes the grouping cleaner and also prepares the code nicely before a larger inspection - many users have complained that the CachedReferenceField is buggy and in many cases unusable and might even be considered for removal).