Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #563 and closes #1002.
This PR introduces tweaks to
QuerySet.as_pymongo- a method that hasn't been touched in at least a couple years. Part of me wants to get rid of it entirely and suggest that people useDoc._get_collection().find(...)if they need raw PyMongo documents, but perhaps that's too drastic of a change (and can be revisited when we make_get_collectionpublic, see #1182).This PR significantly simplifies the code and gets rid of an arguably useless
coerce_typeskwarg (the idea of converting values to MongoEngine-specific types in a method that's supposed to return raw PyMongo documents confuses me greatly). For now I also followed the previous logic of excluding_clsas an implementation detail and also excluding_idif it was only fetched for internal MongoEngine purposes.Even though I suspect this to be barely used, it introduces a breaking change and should hence be released along with a major version bump.
This is off-topic, but I was curious and performed a test of how much faster
as_pymongois compared to the regular queryset iteration:Quite a difference...