Skip to content

Add missing dunder method - __ne__ to the class GridFSProxy class #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2017
Merged

Add missing dunder method - __ne__ to the class GridFSProxy class #1632

merged 1 commit into from
Aug 31, 2017

Conversation

@srinivasreddy
Copy link
Contributor

No description provided.

@srinivasreddy
Copy link
Contributor Author

srinivasreddy commented Aug 30, 2017 •
edited
Loading

@touilleMan Please take a look.

When a dunder __eq__ is define on a class, the __ne__ should also be defined to complete ==, != comparisons.

Thanks!

@touilleMan touilleMan merged commit 5bdd354 into MongoEngine:master Aug 31, 2017
@srinivasreddy srinivasreddy deleted the inequality branch August 31, 2017 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@srinivasreddy @touilleMan