Fixed incorrectly split a query key, when it ends with "_" #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, it's good solution. 👍 |
yograterol
added a commit
that referenced
this pull request
Jun 25, 2014
Fixed incorrectly split a query key, when it ends with "_"
|
This is the last change that builded in Travis 74a3c44 I am seeing other changes. |
|
Well, I don't understand that you mean. I don't find the meaning between what you're asking me and this PR. Sorry :( |
|
Oh oh! Sorry! I get it! The case is that all test with documents have fields with name like "name_field" or "name_field" and not "name_field", hence all test are run ok before and after of this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Say we have a string field called
from_, and we useQ(from___contains='blah')to query against it. However mongoengine seems to interpret this query incorrectly as it use__to split field and operator, which leads tofromand_containswhich is certainly incorrect. I believe we should usersplitto split field and operator since operators are always in the right hand side.